[PATCH] D66985: [llvm-profdata] Recover from InstrProf read failures
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 30 09:07:47 PDT 2019
vsk planned changes to this revision.
vsk added a comment.
Need to add an option to preserve the old error reporting behavior. I'll get back to this on Tuesday.
================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:279
+ if (firstTime)
+ warn(toString(make_error<InstrProfError>(IPE)));
});
----------------
Dor1s wrote:
> How bad will it be if we decide to always print the warning here, not just for the first time?
I agree that reporting of soft errors during merging is not as helpful as it should be. We should come up with a better solution. Istm that warning on all soft errors here could be very annoying (e.g. if there are lots of counter overflows).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66985/new/
https://reviews.llvm.org/D66985
More information about the llvm-commits
mailing list