[PATCH] D67003: AMDGPU: Don't put constants in .text for Mesa

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D67003#1652704 <https://reviews.llvm.org/D67003#1652704>, @cwabbott wrote:

> In D67003#1652687 <https://reviews.llvm.org/D67003#1652687>, @arsenm wrote:
>
> > In D67003#1652686 <https://reviews.llvm.org/D67003#1652686>, @cwabbott wrote:
> >
> > > In D67003#1652676 <https://reviews.llvm.org/D67003#1652676>, @arsenm wrote:
> > >
> > > > Is mesa actually using mesa3d now? I thought we were still in the unpleasant situation where "unknown" OS was treated like mesa3d, but not quite. I thought clover and radv were using mesa3d, but OpenGL was not. If it has, can we finally drop the second scratch implementation?
> > >
> > >
> > > Ugh, you're right, radeonsi still has `target triple = "amdgcn--"`. Why exactly is that? Would anything break if we just changed it to `amdgcn-mesa-mesa3d` like what radv does? I don't want that to block this, though, so is there any other user that needs to return true here? AMDVLK maybe?
> >
> >
> > Mesa is the only oddball relying on the unknown OS behavior. IIRC this required work in mesa to switch the scratch ABI from using relocations to what radv does, but besides that I think everything would work
>
>
> Ok, but what I wanted to ask is whether just deleting this function and just always using `.rodata` is feasible, i.e. whether the only other user (AMDVLK) depends on sticking constant data in `.text`.


I don't think it depends on it, but I'm not sure @dstuttard @tpr @nhaehnle


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67003/new/

https://reviews.llvm.org/D67003