[PATCH] D66338: [CGP] Drop no op intrinsic calls

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 08:42:15 PDT 2019


hfinkel added a comment.

> Is CGP a "mandatory" pass always expected to be executed before ISel? In other words, can we remove logic from SelectionDAGBuilder when rewriting intrinsics here (simply assert that we no longer find intrinsics that should be eliminated by CGP)?

No and no.

> Is it allowed to add passes between CGP and ISel?

A target could certainly do that. This is a good point.

> Some day I hope the pass description for CGP is updated. It is still saying that the pass "should eventually be removed.", but still we add more and more stuff here.

I believe that the thought is that we'll be able to do this once we have GlobalISel.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66338/new/

https://reviews.llvm.org/D66338





More information about the llvm-commits mailing list