[PATCH] D67003: AMDGPU: Don't put constants in .text for Mesa

Connor Abbott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 08:08:51 PDT 2019


cwabbott added a comment.

In D67003#1652676 <https://reviews.llvm.org/D67003#1652676>, @arsenm wrote:

> Is mesa actually using mesa3d now? I thought we were still in the unpleasant situation where "unknown" OS was treated like mesa3d, but not quite. I thought clover and radv were using mesa3d, but OpenGL was not. If it has, can we finally drop the second scratch implementation?


Ugh, you're right, radeonsi still has `target triple = "amdgcn--"`. Why exactly is that? Would anything break if we just changed it to `amdgcn-mesa-mesa3d` like what radv does? I don't want that to block this, though, so is there any other user that needs to return true here? AMDVLK maybe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67003/new/

https://reviews.llvm.org/D67003





More information about the llvm-commits mailing list