[PATCH] D66967: [Attributor] ValueSimplify Abstract Attribute

[Hideto Ueno via Phabricator via llvm-commits]

uenoku added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2517
+      if (!Stripped && this == &AA) {
+        // TODO: Look the instruction and check recursively.
+        indicatePessimisticFixpoint();
----------------
> GenericValueTraversal time ;)
About genericValueTraversal, I couldn't come up with generalized way to handle simplification for each instruction. ex)
```
%call = tail call i32 %fun() ; -> simplified to 1 
%tmp = add i32 %call, 1 ; -> this should be simplified to 2
%tmp2 = mul i32 %tmp, %tmp ;-> this should be simplified to 4
``` 
Do you have any idea?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66967/new/

https://reviews.llvm.org/D66967