[PATCH] D63860: [MachineCSE] Extend CSE heuristic
Piotr Sobczak via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 30 06:02:53 PDT 2019
piotr added a comment.
Thank you for bearing with me, I have been away.
Now, when I re-checked the original case from D63709 <https://reviews.llvm.org/D63709> this morning (cse-phi-incoming-val.ll) I noticed that the extra mov is not present, even without my patch. It turns out that D63198 <https://reviews.llvm.org/D63198> (which was pushed recently) made the original issue go away. I guess, the fact that the issue was in the structurizer kind of explains the observation that other targets seemed to not suffer from similar problems.
Anyway, I intend to just push cse-phi-incoming-val.ll as part of the current review.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63860/new/
https://reviews.llvm.org/D63860
More information about the llvm-commits
mailing list