[PATCH] D66921: GlobalISel: Add known bits to InstructionSelector

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

This change has caused some test failures in our Armv7 only builders http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-full-sh and http://lab.llvm.org:8011/builders/clang-cmake-armv7-full . An example build failure is http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/7366

All the errors are in global isel tests and have the form:

  Pass 'InstructionSelect' is not initialized.
  Verify if there is a pass dependency cycle.
  Required Passes:
  	Target Pass Configuration

It is reproducible on an X86_64 machine, although only when -DLLVM_TARGETS_TO_BUILD="ARM" and only ARM (the bot configuration). If I include AArch64 as well as ARM then the tests pass. I presume this change has added a pass dependency that is not being initialised in the ARM target, but it does if there is another Target that does initialize it. I note that the ARM equivalent of AArch64InstructionSelector doesn't call have the equivalent of setupMF.

Can you take a look?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66921/new/

https://reviews.llvm.org/D66921