[PATCH] D66998: [yaml2obj] - Allow overriding sh_name fields of the sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: include/llvm/ObjectYAML/ELFYAML.h:157
+
+  // The following members are used to override section fields what is
+  // useful for creating invalid objects.
----------------
what -> which


================
Comment at: include/llvm/ObjectYAML/ELFYAML.h:160
+
+  // This can be used to override the offset stored in sh_name field.
+  Optional<llvm::yaml::Hex64> ShName;
----------------
in the sh_name

Perhaps worth mentioning that it does not affect the name stored in the string table.


================
Comment at: test/tools/yaml2obj/elf-override-shname.yaml:1
+## Check we are able to set custom sh_name field
+## for different sections.
----------------
set a custom


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66998/new/

https://reviews.llvm.org/D66998