[PATCH] D66687: [DAGCombiner] try to form more bt/test + set out of shift+mask patterns

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 04:51:43 PDT 2019


spatel added a comment.

In D66687#1652272 <https://reviews.llvm.org/D66687#1652272>, @xbolva00 wrote:

> In D66687#1651582 <https://reviews.llvm.org/D66687#1651582>, @lebedev.ri wrote:
>
> > Looks ok to me.
>
>
> But hexagon’s codegen regressed :(


Yes, although it only regressed after the changes from rL369947 <https://reviews.llvm.org/rL369947> which looks like a response to the earlier rev of this patch.
Ping @kparzysz to see if we should wait for another Hexagon update or if we can proceed and mark those tests with 'TODO'.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66687/new/

https://reviews.llvm.org/D66687





More information about the llvm-commits mailing list