[PATCH] D66886: [yaml2obj][obj2yaml] - Use a single "Other" field instead of "Other", "Visibility" and "StOther".

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: lib/ObjectYAML/ELFYAML.cpp:861
+  NormalizedOther(IO &IO, Optional<uint8_t> Original) : YamlIO(IO) {
+    assert(Original && "This constructor is only used for outputting the YAML "
+                       "and assumes non-empty Original");
----------------
outputting the YAML -> outputting YAML


================
Comment at: lib/ObjectYAML/ELFYAML.cpp:862
+    assert(Original && "This constructor is only used for outputting the YAML "
+                       "and assumes non-empty Original");
+    std::vector<StOtherPiece> Ret;
----------------
assumes a


================
Comment at: lib/ObjectYAML/ELFYAML.cpp:932
+    // consumed first when we print the output, because we do not want to print
+    // another flags that have the same bits instead. So we add it first.
+    if (EMachine == ELF::EM_MIPS) {
----------------
another -> any other
Delete the "So we add it first": you already talk about it being consumed first earlier.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66886/new/

https://reviews.llvm.org/D66886