[PATCH] D66955: [DebugInfo][If-Converter] Update call site info during the optimization

Nikola Prica via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 02:20:10 PDT 2019


NikolaPrica marked an inline comment as done.
NikolaPrica added inline comments.


================
Comment at: test/CodeGen/ARM/smml.ll:13
+; call site info state.
+; RUN: llc -stop-after=if-converter -debug-entry-values -mtriple=thumbv6t2-eabi %s -o -| FileCheck %s -check-prefix=CHECK-CALLSITE
+; CHECK-CALLSITE: name:  test_used_flags
----------------
vsk wrote:
> How did you catch this?
> 
> Have you run the test suite using "./bin/llvm-lit -Dllc="llc -debug-entry-values"?
I've built couple of binaries that triggered the assertion and then resolved it.  Since I was testing for the ARM I just replaced `updatedCallSiteInfo` with an assertion and run all ARM tests to see whether it will trigger something. But the call you mentioned is simpler one! I will try it in future! Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66955/new/

https://reviews.llvm.org/D66955





More information about the llvm-commits mailing list