[PATCH] D66980: [Windows] Disable TrapUnreachable for Win64, add SEH_NoReturn

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

I'm also not familiar with the unwinder and exception handling, but the code itself and the explanation seems good to me.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:4117
 
+  if (CLI.DoesNotReturn && Subtarget.isTargetWin64()) {
+    Chain = DAG.getNode(X86ISD::SEH_NORETURN, dl, NodeTys, Chain, InFlag);
----------------
Maybe add a comment clarifying why this gets inserted here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66980/new/

https://reviews.llvm.org/D66980