[PATCH] D66985: [llvm-profdata] Recover from InstrProf read failures

Max Moroz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 21:33:35 PDT 2019


Dor1s added subscribers: sajjadm, liaoyuke.
Dor1s added a comment.

That's a great change, Vedant!! Thank you! //cc @sajjadm @liaoyuke FYI

Might make sense to clarify in the description that this is for merge only, if I understand correctly :)



================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:279
+    if (firstTime)
+      warn(toString(make_error<InstrProfError>(IPE)));
   });
----------------
How bad will it be if we decide to always print the warning here, not just for the first time?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66985/new/

https://reviews.llvm.org/D66985





More information about the llvm-commits mailing list