[PATCH] D66979: [InstrProf] Tighten a check for malformed data records in raw profiles

[Max Moroz via Phabricator via llvm-commits]

Dor1s accepted this revision.
Dor1s added a comment.
This revision is now accepted and ready to land.

Pardon my ignorance, but what does `rdar://54843625` mean? I guess it's not http://openradar.appspot.com/54843625 ? Is it something I can access? :)



================
Comment at: llvm/include/llvm/ProfileData/InstrProfReader.h:271
 
-  const uint64_t *getCounter(IntPtrT CounterPtr) const {
-    ptrdiff_t Offset = (swap(CounterPtr) - CountersDelta) / sizeof(uint64_t);
+  ptrdiff_t getCounterOffset(IntPtrT CounterPtr) const {
+    return (swap(CounterPtr) - CountersDelta) / sizeof(uint64_t);
----------------
davidxl wrote:
> add a documentation " Returns the double word offset of a counter to the start of the counter segment'
is `uint64_t` a "double word"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66979/new/

https://reviews.llvm.org/D66979