[PATCH] D65893: [llvm-objcopy] Allow the visibility of symbols created by --binary and --add-symbol to be specified with --new-symbol-visibility
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 29 18:59:18 PDT 2019
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.h:951
+ BinaryReader(const MachineInfo &MI, MemoryBuffer *MB,
+ const uint8_t NewSymbolVisibility)
+ : MInfo(MI), MemBuf(MB), NewSymbolVisibility(NewSymbolVisibility) {}
----------------
`const uint8_t` -> `uint8_t`
The parameter doesn't have to use const.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65893/new/
https://reviews.llvm.org/D65893
More information about the llvm-commits
mailing list