[PATCH] D66338: [CGP] Drop no op intrinsic calls

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:1856
     default: break;
+    case Intrinsic::sideeffect: {
+      II->eraseFromParent();
----------------
The others look fine to me (although, honestly, I don't understand how var_annotation is really used), but dropping llvm::sideeffect in CGP makes me really nervous. This is necessary for correctness in the places where it's used, and could lead to invalid analysis/transformation results in post-CGP IR passes/analysis. I recommend not doing this here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66338/new/

https://reviews.llvm.org/D66338