[PATCH] D66976: Small update to Expected<StringRef>
Sid Manning via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 29 15:13:52 PDT 2019
sidneym created this revision.
sidneym added reviewers: grimar, MaskRay, sbc100, bcain.
Herald added a subscriber: rupprecht.
Herald added a project: LLVM.
I think this was missed when the original change was made. Should have used NameOrErr instead of SecIOrErr.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D66976
Files:
llvm/tools/llvm-nm/llvm-nm.cpp
Index: llvm/tools/llvm-nm/llvm-nm.cpp
===================================================================
--- llvm/tools/llvm-nm/llvm-nm.cpp
+++ llvm/tools/llvm-nm/llvm-nm.cpp
@@ -1099,7 +1099,7 @@
Expected<StringRef> NameOrErr = (*SecIOrErr)->getName();
if (!NameOrErr) {
- consumeError(SecIOrErr.takeError());
+ consumeError(NameOrErr.takeError());
return '?';
}
SecName = *NameOrErr;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66976.217981.patch
Type: text/x-patch
Size: 440 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190829/94fb896e/attachment.bin>
More information about the llvm-commits
mailing list