[PATCH] D66942: [DebugInfo] LiveDebugValues: locations with different exprs should compare differently

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.
Herald added a subscriber: ormris.

This makes sense, I'm kind of shocked that me missed something that obvious. Is there a big drop in variable locations with this (i.e., an improvement in accuracy)?



================
Comment at: lib/CodeGen/LiveDebugValues.cpp:196
+    /// The (potentially complex) expression applied to this location.
+    const DIExpression *Expr;
+
----------------
Do you need to store this here, or could you derive it from MI below?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66942/new/

https://reviews.llvm.org/D66942