[PATCH] D66974: Allow '@' to appear in x86 mingw symbols

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 14:14:03 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL370408: Allow '@' to appear in x86 mingw symbols (authored by rnk, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D66974?vs=217970&id=217972#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66974/new/

https://reviews.llvm.org/D66974

Files:
  llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp
  llvm/trunk/test/MC/X86/stdcall.s


Index: llvm/trunk/test/MC/X86/stdcall.s
===================================================================
--- llvm/trunk/test/MC/X86/stdcall.s
+++ llvm/trunk/test/MC/X86/stdcall.s
@@ -0,0 +1,19 @@
+# RUN: llvm-mc %s -filetype=obj -o - -triple i686-windows-msvc | llvm-nm - | FileCheck %s
+# RUN: llvm-mc %s -filetype=obj -o - -triple i686-windows-gnu | llvm-nm - | FileCheck %s
+
+# CHECK: T _mystdcall at 8{{$}}
+# CHECK: T foo
+
+.text
+.global _mystdcall at 8
+_mystdcall at 8:
+	movl 4(%esp), %eax
+	addl 8(%esp), %eax
+	retl $8
+
+.global foo
+foo:
+	pushl $1
+	pushl $2
+	calll _mystdcall at 8
+	retl
Index: llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp
===================================================================
--- llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp
+++ llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp
@@ -163,5 +163,7 @@
 
   TextAlignFillValue = 0x90;
 
+  AllowAtInName = true;
+
   UseIntegratedAssembler = true;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66974.217972.patch
Type: text/x-patch
Size: 966 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190829/4fdcb09b/attachment.bin>


More information about the llvm-commits mailing list