[PATCH] D66824: [09/10] [LLD] [COFF] Support merging resource object files

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D66824#1651639 <https://reviews.llvm.org/D66824#1651639>, @thakis wrote:

> >> Do you really need this feature in MinGW mode? IIRC you said this was for some "default res file" feature in gcc which adds a default res which is only supposed to be used if there's no user res file -- which doesn't require any merging.
> > 
> > The user resource object file could be other resources (icons and dialogs and whatnot), where the manifest is supposed to be merged with the rest. Only if the user resources happens to have a manifest should the implicit default one be dropped.
>
> Wouldn't users pass .res files to the linker? If not, why not?


GNU ld doesn't support .res files at all, it only supports resource object files, so that's how it's always been done in MinGW project builds. (But these days, GNU ld _does_ have this whole resource object unpacking and merging logic, but still no support for plain .res files.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66824/new/

https://reviews.llvm.org/D66824