[PATCH] D66820: [06/10] [COFF] Add a ResourceSectionRef method for getting resource contents

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 13:41:15 PDT 2019


mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: llvm/test/tools/llvm-cvtres/combined.test:37
 CHECK-NEXT:          Reserved: 0
+CHECK-NEXT:          Data (
+CHECK:               )
----------------
thakis wrote:
> These `Data (` sections here print data, but since the next line says CHECK instead of CHECK-NEXT we just don't print hit here, right?
Yes, I didn't want to bloat the test with all the bulk raw data here. I kept one entry at the top of coff-resources.test where I have a check for the full printout.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66820/new/

https://reviews.llvm.org/D66820





More information about the llvm-commits mailing list