[PATCH] D66968: [WebAssembly] Implement NO_STRIP

[Dan Gohman via Phabricator via llvm-commits]

sunfish added a comment.

In D66968#1651483 <https://reviews.llvm.org/D66968#1651483>, @sbc100 wrote:

> I'm curious why a user would want to use WASM_SYMBOL_NO_STRIP if it doesn't export the symbol?  Maybe for post-linker to do stuff perhaps?


I've seen people use it to make something available in a debugger. But in any case, this is how `__attribute__((used))` works on other platforms.

> Do you have plan for how you want to allow llvm user to export symbols with `wasm32-wasi`?   Presumably using custom __attribute__?

I don't have a specific proposal yet, but yes, I'm picturing something like `__attribute__((export_name("foo")))`.

> Presumably tests will go with the followup CLs?

Oops, I lost the test change when I removed the other changes from the patch. I've now included it.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66968/new/

https://reviews.llvm.org/D66968