[PATCH] D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool.

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

Please rename the tests to be more meaningful so that others can possibly identify what they are meant to test and can address things which may break when other changes are made.



================
Comment at: llvm/test/tools/llvm-ifs/a-conflict-type.ifs:6
+# merge in conflict due to mismatched types.
+# CHECK-IFS: error: Interface Stub: Type Mismatch for a.
+
----------------
Should we diagnose the types which are conflicting?


================
Comment at: llvm/test/tools/llvm-ifs/a-conflict-weak.ifs:7
+# when llvm-ifs has support for resolving these kinds of conflicts.
+# CHECK-IFS: error: Interface Stub: Weak Mismatch for a.
+
----------------
The diagnostic is difficult to understand.  Perhaps make this similar to the diagnostic for the mismatched types, and indicate that the failure is that the symbol is weak.


================
Comment at: llvm/tools/llvm-ifs/llvm-ifs.cpp:40
+
+static cl::opt<std::string> Action("a", cl::desc("<llvm-ifs action>"),
+                                   cl::value_desc("write-ifs | write-bin"),
----------------
Why no long name?


================
Comment at: llvm/tools/llvm-ifs/llvm-ifs.cpp:44
+
+static cl::opt<std::string> ForceFormat("f", cl::desc("<force object format>"),
+                                        cl::value_desc("ELF | TBD"),
----------------
Same


================
Comment at: llvm/tools/llvm-ifs/llvm-ifs.cpp:52
+
+static cl::opt<std::string> OutputFilename("o", cl::desc("<output file>"),
+                                           cl::value_desc("path"));
----------------
Same


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66405/new/

https://reviews.llvm.org/D66405