[PATCH] D66968: [WebAssembly] Implement NO_STRIP

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 12:04:03 PDT 2019


sbc100 added a comment.

I'm curious why a user would want to use WASM_SYMBOL_NO_STRIP if it doesn't export the symbol?  Maybe for post-linker to do stuff perhaps?

Do you have plan for how you want to allow llvm user to export symbols with `wasm32-wasi`?   Presumably using custom __attribute__?

Presumably tests will go with the followup CLs?



================
Comment at: tools/lld/wasm/MarkLive.cpp:72
 
   // We need to preserve any exported symbol
   for (Symbol *sym : symtab->getSymbols())
----------------
Update the comment?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66968/new/

https://reviews.llvm.org/D66968





More information about the llvm-commits mailing list