[PATCH] D66950: [SimplifyCFG] Skip sinking common lifetime markers of `alloca`.

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 08:44:06 PDT 2019


jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.

Thanks! One nit.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1495
+
+  auto isLifeTimeMarker = [](const Instruction *I) {
+    if (auto II = dyn_cast<IntrinsicInst>(I)) {
----------------
Nit: I'd prefer this out of line as it doesn't use any state from this function and its intent is clear from the name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66950/new/

https://reviews.llvm.org/D66950





More information about the llvm-commits mailing list