[PATCH] D65884: [ARM] MVE Tail Predication

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 08:00:30 PDT 2019


SjoerdMeijer added inline comments.


================
Comment at: lib/Target/ARM/MVETailPredication.cpp:301
+        unsigned ElementWidth = VecTy->getScalarSizeInBits();
+        if (Lanes * ElementWidth != 128 || Lanes == 128)
+          return false;
----------------
A few nits I forgot to mention in my previous message:

Replace constant 128 with `TTI.getRegisterBitWidth(true)`?

And I don't think I understand the `Lanes == 128` part.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65884/new/

https://reviews.llvm.org/D65884





More information about the llvm-commits mailing list