[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: cfe/trunk/include/clang/Index/IndexingAction.h:58
+    const IndexingOptions &Opts, std::shared_ptr<Preprocessor> PP,
+    std::function<bool(const Decl *)> ShouldSkipFunctionBody);
+
----------------
I know ShouldSkipFunctionBody is important for multi-threaded indexing, but why is it a mandatory argument?

There are lots of other overloads, are they good candidates for being mandatory arguments?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66879/new/

https://reviews.llvm.org/D66879