[PATCH] D66803: [LV] Tail-folding with runtime memory checks

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 05:31:03 PDT 2019


SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/tail-folding-memcheck.ll:13
+; CHECK: @llvm.masked.store.v8i32.p0v8i32
+; CHECK: br i1 %12, label %middle.block, label %vector.body
+entry:
----------------
Ayal wrote:
> Better avoid hard coded values such as `%12`.
> E.g., see what utils/update_test_checks.py makes of it.
Thanks for spotting, copy-paste mistake.
I think checking the masked loads/stores and the labels is good enough (and conciser), but if you think it is better I can run the script.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66803/new/

https://reviews.llvm.org/D66803





More information about the llvm-commits mailing list