[PATCH] D66803: [LV] Tail-folding with runtime memory checks

[Ayal Zaks via Phabricator via llvm-commits]

Ayal added a comment.

In D66803#1650509 <https://reviews.llvm.org/D66803#1650509>, @SjoerdMeijer wrote:

> I have addressed the other assert in D66932 <https://reviews.llvm.org/D66932>.


OK, great, then the FIXME is probably redundant.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:2732
 
-  assert(!Cost->foldTailByMasking() && "Cannot check memory when folding tail");
   // Create a new block containing the memory check.
----------------
Replace the assert so that it checks hasOptSize, instead of removing it?


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/tail-folding-memcheck.ll:13
+; CHECK: @llvm.masked.store.v8i32.p0v8i32
+; CHECK: br i1 %12, label %middle.block, label %vector.body
+entry:
----------------
Better avoid hard coded values such as `%12`.
E.g., see what utils/update_test_checks.py makes of it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66803/new/

https://reviews.llvm.org/D66803