[PATCH] D66931: [llvm-objcopy] Simplify --prefix-alloc-sections

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I agree that this code is simpler, but I'm slightly hesitant you might have impaired performance of the loop, since we now have to loop over all sections twice when using both --prefix-alloc-sections and --rename-sections switches. Admittedly, I suspect this is a rare case (I still don't know of a reasonable use-case for --prefix-alloc-sections), so maybe it's not worth worrying about. @rupprecht, I think you had some performance issues with llvm-objcopy in the past. Do you have any insight into whether my concern is justified? If not, LGTM.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66931/new/

https://reviews.llvm.org/D66931