[PATCH] D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

@dstenb Thanks a lot for the test case, I will take a look into that.

> Another comment I made in an earlier review is that it is also reasonable to have completely different semantics for DW_OP_entry_value in LLVM IR; in which case it would be best to introduce an IR-only DW_OP_LLVM_entry_value (like DW_OP_LLVM_fragment) to avoid confusion and lower that to a real DWARF opcode in AsmPrinter.

@aprantl I agree with this... That will simplify things a lot, especially future work.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66746/new/

https://reviews.llvm.org/D66746