[PATCH] D66913: [Attributor] Use the whitelist for attributes consistently

[Hideto Ueno via Phabricator via llvm-commits]

uenoku added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:777
+            KindToAbstractAttributeMap.lookup(&AAType::ID))) {
+      // Do not registr a dependence on an attribute with an invalid state.
+      if (TrackDependence && AA->getState().isValidState())
----------------
register


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1308-1309
     Function *F = getAssociatedFunction();
+    if (!F)
+      return indicatePessimisticFixpoint();
     const IRPosition &FnPos = IRPosition::function(*F);
----------------
I'm not sure why this check is here. Why not in `initialize`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66913/new/

https://reviews.llvm.org/D66913