[PATCH] D65893: [llvm-objcopy] Allow the visibility of symbols created by --binary and --add-symbol to be specified with --new-symbol-visibility

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 22:29:20 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:509
+          "'" + InputArgs.getLastArgValue(OBJCOPY_new_symbol_visibility) +
+              "' is not a valid binary symbol visibility");
+  }
----------------
`binary symbol visibility` -> `symbol visibility`



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65893/new/

https://reviews.llvm.org/D65893





More information about the llvm-commits mailing list