[PATCH] D66785: [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32

[Bing Yu via Phabricator via llvm-commits]

yubing marked 2 inline comments as done.
yubing added inline comments.


================
Comment at: clang/lib/Headers/avx512fintrin.h:9662
 
+static __inline__ int __DEFAULT_FN_ATTRS512
+_mm512_cvtsi512_si32(__m512i __A) {
----------------
RKSimon wrote:
> Since we're adding this, we should set an example and include the doxygen comment as well (even though avx512 intrinsics aren't well documented). You should be able to copy the doxygen from _mm_cvtsi128_si32 in emmintrin.h with only trivial edits
Thanks for comments, I will fix them


================
Comment at: clang/test/CodeGen/avx512f-builtins.c:10849
+
+int test_mm512_cvtsi512_si32(__m512i a) {
+  // CHECK-LABEL: test_mm512_cvtsi512_si32
----------------
RKSimon wrote:
> Put in alphabetical order? I make that just after test_mm_cvtsd_u32 ?
Do we really need to put them in alphabetical order?
It seems testcases in  this file are out of order.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66785/new/

https://reviews.llvm.org/D66785