[llvm] r370271 - [LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to llvm_add_library()

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 16:37:58 PDT 2019


On 08/28/2019 03:59 PM, Tom Stellard via llvm-commits wrote:
> Author: tstellar
> Date: Wed Aug 28 15:59:04 2019
> New Revision: 370271
> 

Hi Hans,

Could we get this merged to the 9.0 branch?

Thanks,
Tom


> URL: http://llvm.org/viewvc/llvm-project?rev=370271&view=rev
> Log:
> [LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to llvm_add_library()
> 
> Due to a misstake with r365902 that tried to simplify the install with
> toolchain logic LLVM-C.dll was no longer being installed.
> 
> Patch By: Jakob Bornecrantz
> 
> Modified:
>     llvm/trunk/tools/llvm-shlib/CMakeLists.txt
> 
> Modified: llvm/trunk/tools/llvm-shlib/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-shlib/CMakeLists.txt?rev=370271&r1=370270&r2=370271&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-shlib/CMakeLists.txt (original)
> +++ llvm/trunk/tools/llvm-shlib/CMakeLists.txt Wed Aug 28 15:59:04 2019
> @@ -182,6 +182,6 @@ if(MSVC)
>      VERBATIM )
>  
>    # Finally link the target.
> -  add_llvm_library(LLVM-C SHARED ${SOURCES} DEPENDS intrinsics_gen)
> +  add_llvm_library(LLVM-C SHARED INSTALL_WITH_TOOLCHAIN ${SOURCES} DEPENDS intrinsics_gen)
>  
>  endif()
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 



More information about the llvm-commits mailing list