[PATCH] D66901: [ObjectYAML] Fix lifetime issue in dumpDebugLines

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka updated this revision to Diff 217720.
vitalybuka added a comment.

proper fix and test update


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66901/new/

https://reviews.llvm.org/D66901

Files:
  llvm/test/ObjectYAML/MachO/DWARF-debug_line.yaml
  llvm/tools/obj2yaml/dwarf2yaml.cpp


Index: llvm/tools/obj2yaml/dwarf2yaml.cpp
===================================================================
--- llvm/tools/obj2yaml/dwarf2yaml.cpp
+++ llvm/tools/obj2yaml/dwarf2yaml.cpp
@@ -287,7 +287,7 @@
       const uint64_t LineEnd =
           LineTableLength + *StmtOffset + SizeOfPrologueLength;
       while (Offset < LineEnd) {
-        DWARFYAML::LineTableOpcode NewOp;
+        DWARFYAML::LineTableOpcode NewOp = {};
         NewOp.Opcode = (dwarf::LineNumberOps)LineData.getU8(&Offset);
         if (NewOp.Opcode == 0) {
           auto StartExt = Offset;
Index: llvm/test/ObjectYAML/MachO/DWARF-debug_line.yaml
===================================================================
--- llvm/test/ObjectYAML/MachO/DWARF-debug_line.yaml
+++ llvm/test/ObjectYAML/MachO/DWARF-debug_line.yaml
@@ -557,21 +557,21 @@
 #CHECK:           SubOpcode:       DW_LNE_set_address
 #CHECK:           Data:            4294971216
 #CHECK:         - Opcode:          0x14
-#CHECK:           Data:            4294971216
+#CHECK:           Data:            0
 #CHECK:         - Opcode:          DW_LNS_set_column
 #CHECK:           Data:            3
 #CHECK:         - Opcode:          DW_LNS_set_prologue_end
-#CHECK:           Data:            3
+#CHECK:           Data:            0
 #CHECK:         - Opcode:          DW_LNS_const_add_pc
-#CHECK:           Data:            3
+#CHECK:           Data:            0
 #CHECK:         - Opcode:          0xBB
-#CHECK:           Data:            3
+#CHECK:           Data:            0
 #CHECK:         - Opcode:          0xBB
-#CHECK:           Data:            3
+#CHECK:           Data:            0
 #CHECK:         - Opcode:          DW_LNS_advance_pc
 #CHECK:           Data:            11
 #CHECK:         - Opcode:          DW_LNS_extended_op
 #CHECK:           ExtLen:          1
 #CHECK:           SubOpcode:       DW_LNE_end_sequence
-#CHECK:           Data:            11
+#CHECK:           Data:            0
 #CHECK: ...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66901.217720.patch
Type: text/x-patch
Size: 1976 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190828/d4ff9b51/attachment-0001.bin>