[PATCH] D66888: [LiveDebugValues] Insert entry values after bundles

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 13:37:36 PDT 2019


aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1271-1272
     for (auto &TR : Transfers) {
-      MBB.insertAfter(MachineBasicBlock::iterator(*TR.TransferInst),
-                     TR.DebugInst);
+      MBB.insert(std::next(MachineBasicBlock::iterator(*TR.TransferInst)),
+                 TR.DebugInst);
     }
----------------
dstenb wrote:
> A downstream comment was that this perhaps should become a helper function, e.g. `MachineBasicBlock::insertAfterBundled()`.
I think this would be much more readable indeed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66888/new/

https://reviews.llvm.org/D66888





More information about the llvm-commits mailing list