[PATCH] D66897: [AArch64][GlobalISel] Select @llvm.aarch64.ldaxr.* intrinsics

[Amara Emerson via Phabricator via llvm-commits]

aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

The new test can be made more concise, but it's also a bit redundant given we're adding checks to an existing one. I don't mind either way.



================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/select-ldaxr-intrin.mir:32
+    %0:gpr(p0) = COPY $x0
+    %4:gpr(p0) = G_GLOBAL_VALUE @var
+    %1:gpr(s64) = G_INTRINSIC_W_SIDE_EFFECTS intrinsic(@llvm.aarch64.ldaxr), %0(p0) :: (volatile load 1 from %ir.addr)
----------------
Just use a pointer parameter here instead of a global?


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/select-ldaxr-intrin.mir:37
+    %3:gpr(s64) = G_AND %6, %5
+    G_STORE %3(s64), %4(p0) :: (store 8 into @var)
+    RET_ReallyLR
----------------
And return the value here to reduce the test size.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66897/new/

https://reviews.llvm.org/D66897