[PATCH] D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result

[Simon Dardis via Phabricator via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/Mips/Mips.td:28
   list<Predicate> PTRPredicates = [];
+  // Predicates for the symbol's size such as hasSym32
+  list<Predicate> SYMPredicates = [];
----------------
Nit: Predicates for a symbol's sizee such as hasSym32.


================
Comment at: llvm/lib/Target/Mips/Mips64InstrInfo.td:654
                 (JAL texternalsym:$dst)>, ISA_MIPS3, GPR_64, SYM_64;
+
   def : MipsPat<(MipsHighest (i64 tglobaladdr:$in)),
----------------
Touch up the formatting in a separate NFC commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66228/new/

https://reviews.llvm.org/D66228