[PATCH] D66383: [InstCombine] Shift amount reassociation in bittest: trunc-of-lshr (PR42399)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 12:30:58 PDT 2019


lebedev.ri added a comment.

In D66383#1649684 <https://reviews.llvm.org/D66383#1649684>, @spatel wrote:

> LGTM


Thank you for the review!

> still complicated, but easier to read without the ConstExpr logic. :)

Yeah :/ I'm likely missing some generalization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66383/new/

https://reviews.llvm.org/D66383





More information about the llvm-commits mailing list