[PATCH] D66769: [GlobalISel] Import patterns containing SUBREG_TO_REG

[Daniel Sanders via Phabricator via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM aside from the redundant movl's. I see you've already commented on those though and given that another pass is introducing them it should probably be on that pass to avoid them if they're truly redundant



================
Comment at: llvm/test/CodeGen/X86/GlobalISel/add-ext.ll:205
 ; CHECK-NEXT:    leal 1(%rsi), %eax
+; CHECK-NEXT:    movl %eax, %eax
 ; CHECK-NEXT:    movq $4, %rcx
----------------
Redundant movl instruction?


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/add-ext.ll:210
 ; CHECK-NEXT:    leal 2(%rsi), %edx
+; CHECK-NEXT:    movl %edx, %edx
 ; CHECK-NEXT:    imulq %rcx, %rdx
----------------
Redundant movl instruction?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66769/new/

https://reviews.llvm.org/D66769