[PATCH] D66885: [TSan] Add read/write range interface functions with PC

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 11:09:43 PDT 2019


dvyukov added a comment.

Thanks for the background. Good to know.

I think we could actually do common cross-sanitizer annotation for this in common_interface_defs.h. We already have e.g. __sanitizer_unaligned_load/storeN there that are implemented by all sanitizers.
Access annotations are historically separate, but it makes sense to have a common one. Asan also has __asan_address_is_poisoned/__asan_region_is_poisoned.
Kostya, Eugenii, Vitaly, any objections to adding something like __sanitizer_read/write_range_pc?
There is a question of what to do in msan versions. Should read to the checking? Should write unpoison?  But we could choose what we expect to be more common case and add other special versions for msan if necessary later.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66885/new/

https://reviews.llvm.org/D66885





More information about the llvm-commits mailing list