[PATCH] D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool.

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi marked 6 inline comments as done.
plotfi added inline comments.


================
Comment at: llvm/test/tools/llvm-ifs/a-conflict-header-version.ifs:7
+
+# CHECK-IFS: error: Interface Stub: IfsVersion Mismatch.
+# CHECK-IFS2: error: Interface Stub: Bad IfsVersion: 0.0, llvm-ifs supported version: 1.0.
----------------
compnerd wrote:
> Does it matter if the version is mismatched between the two versions as long as you can deserialise and merge?
I think what i'll do is, if the major versions are different then error out but if the minors are different then resolve any difference. 


================
Comment at: llvm/test/tools/llvm-ifs/a-conflict-type.ifs:13
+Symbols:
+  a: { Type: Object, Size: 1}
+...
----------------
compnerd wrote:
> Missing space before the `}`.
Aye


================
Comment at: llvm/test/tools/llvm-ifs/a-conflict-weak.ifs:7
+# when llvm-ifs has support for resolving these kinds of conflicts.
+# CHECK-IFS: error: Interface Stub: Weak Mismatch for a.
+
----------------
compnerd wrote:
> mmm...I think that we should verify that this is appropriate behaviour.  I think that the linker will normally accept the weak definition and replace it with the strong definition and we should just upgrade to the strong definition.
Can I add this resolution in a followup? it was my intention to do the more complicated resolution in a followup just so the patches stay simpler


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66405/new/

https://reviews.llvm.org/D66405