[PATCH] D42712: [utils] Add utils/update_cc_test_checks.py
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 28 10:46:11 PDT 2019
vsk added inline comments.
Herald added a project: LLVM.
================
Comment at: llvm/trunk/utils/update_cc_test_checks.py:100
+ print('Please specify --llvm-bin or --clang', file=sys.stderr)
+ sys.exit(1)
+ if args.c_index_test is None:
----------------
Just a heads-up: find_executable doesn't seem to do the right thing here when clang is found within 'llvm_bin'. It rejects the full path to clang as it isn't technically in PATH.
================
Comment at: llvm/trunk/utils/update_cc_test_checks.py:108
+ print('Please specify --llvm-bin or --c-index-test', file=sys.stderr)
+ sys.exit(1)
+
----------------
Ditto.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D42712/new/
https://reviews.llvm.org/D42712
More information about the llvm-commits
mailing list