[PATCH] D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries
Jinsong Ji via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 28 10:28:26 PDT 2019
jsji added a comment.
> A separate pass for MASSV lowering is worthwhile because it allows better separation of concerns.
> In the future, if need be, other PPC sub-target specific lowering decisions for MASSV may be encapsulated in this pass too.
What is the benefits other than `allows better separation of concerns`?
I don't see this compelling reason to be a pass, especially considering the unnecessary compile time it will cost.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59883/new/
https://reviews.llvm.org/D59883
More information about the llvm-commits
mailing list