[PATCH] D66309: Introduce infrastructure for an incremental port of SelectionDAG atomic load/store handling

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 09:29:55 PDT 2019


reames added a comment.

In D66309#1643783 <https://reviews.llvm.org/D66309#1643783>, @efriedma wrote:

> Is there an llvm-dev thread for the general project?  It looks fine to me, but maybe it should have a wider audience.


Will do.

> Are you planning to move all atomic load/store operations to this framework, eventually, or just unordered ones?

Honestly, haven't decided.  My near term needs are for unordered only.

> Do you have any test coverage for code using the flags from an unordered load folded into arithmetic, or a folded RMW operation?

See test/CodeGen/X86/atomic-unordered.ll @rmw_fold_* for the later.  
Will add the flag checks, I don't have those (I think).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66309/new/

https://reviews.llvm.org/D66309





More information about the llvm-commits mailing list