[PATCH] D65280: Add a pass to lower is.constant and objectsize intrinsics

Wed Aug 28 07:40:24 PDT 2019

jyknight added a comment.

In D65280#1649062 <https://reviews.llvm.org/D65280#1649062>, @hans wrote:

> > Can we not get the entire thing merged? I'd really like that... I think the patch is actually really close. I have a bunch of comments below but they're all pretty boring in reality.
>
> It's really late in the process -- as in I'm only really waiting for this and one other bug -- so I'm hesitant to take a large change, but I also don't really understand exactly what's at stake here.

I'm also against putting it into 9.0, which is supposed to have a final release Real Soon Now. This is not a obviously-correct change, and it should bake in trunk for at least a couple weeks before going into the release, to shake out any unexpected problems.

I think we //should// target this for the 9.0.1 patch though, which is why joerg wants to merge the API change to 9.0 now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65280/new/

https://reviews.llvm.org/D65280