[PATCH] D66383: [InstCombine] Shift amount reassociation in bittest: trunc-of-lshr (PR42399)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D66383#1648970 <https://reviews.llvm.org/D66383#1648970>, @xbolva00 wrote:

> Does this show up in bootstrap/test suite?


I have not checked this particular pattern extensions,
but i know it does appear in hotspots in my code which is why i'm trying to add these folds :S

> Rare folds with big pattern matching should go to AgressiveInstCombine.

Yes it is a concern indeed, but we've had this disscussion in https://reviews.llvm.org/D64512#1587640 already, this isn't much different.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66383/new/

https://reviews.llvm.org/D66383