[PATCH] D66642: [yaml2obj] - Don't allow setting StOther and Other/Visibility at the same time.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 06:26:33 PDT 2019


grimar added a comment.

In D66642#1648848 <https://reviews.llvm.org/D66642#1648848>, @MaskRay wrote:

> This was reverted by rL370198 <https://reviews.llvm.org/rL370198>


Yes. Seems there is an uninitialized variable, I do not see it though (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/14395/steps/check-llvm%20msan/logs/stdio)
I am going to post a patch that suggests to eliminate the 'Visibility' and 'StOther' soon. So we probably will not need this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66642/new/

https://reviews.llvm.org/D66642





More information about the llvm-commits mailing list