[PATCH] D66804: [TargetLowering] Add buildLegalVectorShuffle facility to help build legal shuffles

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 03:44:07 PDT 2019


RKSimon accepted this revision.
RKSimon added a comment.

LGTM



================
Comment at: include/llvm/CodeGen/TargetLowering.h:3196
+  /// Tries to build a legal vector shuffle using the provided parameters
+  /// or equivalent variations. Return an empty SValue if the operation fails.
+  SDValue buildLegalVectorShuffle(EVT VT, const SDLoc &DL, SDValue N0,
----------------
Make it clear that Mask may be altered whether this function succeeds or fails.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66804/new/

https://reviews.llvm.org/D66804





More information about the llvm-commits mailing list